Use cluster title in modbrowser versions table

[hansen-m]

Cluster column value in versions table should use the cluster title to match the toolbar cluster filter menu values

[Bubballoo3]

We actually have an ood_core method for this on the cluster object itself, see #4869. Thanks for noticing this spot where it was forgotten though!

[hansen-m]

@Bubballoo3 Thanks for the feedback and reference. I'm still learning more about how this code works.

It looks like the clusters variable being passed is just a string derived from the modules versions instead of the cluster object. Wouldn't there still need to be a lookup to use the title? Similar to the toolbar.

I could move the cluster object lookup up to the module_list and pass it the cluster objects instead of strings if that would make more sense here.

<% clusters  = versions.map(&:cluster).uniq.map { |id| Configuration.job_clusters[id.to_s] }.compact %>
<%= render 'versions_table', versions: versions, clusters: clusters %>

Is there a better way?

[Bubballoo3]

🤦‍♂️You're right, sorry about that! This is definitely the simplest way to get the title. Thanks again for the contribution!

[johrstrom]

Thanks!