WKT/PROJJSON datum ensemble import: allow no members #4606
Merged
+1,454
−1,318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the future extension of the ETRS89 datum ensemble to all recently created ETRS89-XX national datums, the number of members in the ensemble will be huge and will make ugly WKT/PROJJSON, hence it is highly likely that listing the members will be made optional. Be tolerant of that on the parsing size, but still emit them on export for now.
rouault
added
funded through GSP
Contributor
|
Was it a problem not having a member of the ensemble? What happened if you had an "old" WKT from WGS84 before they added the last realization (not so long ago) ? Was it failing? |
Member
Author
lacking all members was rejected. Lacking one member or having extra members was fine, at least for coordinate transformation purposes, since testing for equality stops at comparing the datum ensemble name, not its members
no, that was fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the future extension of the ETRS89 datum ensemble to all recently created ETRS89-XX national datums, the number of members in the ensemble will be huge and will make ugly WKT/PROJJSON, hence it is highly likely that listing the members will be made optional. Be tolerant of that on the parsing size, but still emit them on export for now.