cmake: add math lib to r.flowaccumulation and r.skyline#1618
Open
nilason wants to merge 1 commit intoOSGeo:grass8from
Open
cmake: add math lib to r.flowaccumulation and r.skyline#1618nilason wants to merge 1 commit intoOSGeo:grass8from
nilason wants to merge 1 commit intoOSGeo:grass8from
Conversation
wenzeslaus
approved these changes
Feb 13, 2026
Member
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
Thanks. I was looking forward to seeing the dependency handling in addons with CMake.
cwhite911
requested changes
Feb 13, 2026
| @@ -52,5 +54,6 @@ set(doc_files | |||
| build_addon( | |||
| ${PROJECT_NAME} | |||
| GRASSLIBS gis raster | |||
Contributor
There was a problem hiding this comment.
Based on the original Makefile it looks like the vector , dbmibase, dbmiclient, and dbmidriver need to be included as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add math library as dependency to r.flowaccumulation and r.skyline.
Addresses issue raised in #1592 (comment).