r.curvenumber: Add dual HSG support and null-soil fallback#1636
Merged
petrasovaa merged 5 commits intoOSGeo:grass8from Mar 5, 2026
Merged
r.curvenumber: Add dual HSG support and null-soil fallback#1636petrasovaa merged 5 commits intoOSGeo:grass8from
petrasovaa merged 5 commits intoOSGeo:grass8from
Conversation
Resolve dual hydrologic soil groups (A/D, B/D, C/D, D/D encoded as 11-14) to single groups based on drainage condition. Add -d flag to select drained behavior (uses first group); default is undrained (uses second group). Fall back to HSG D when soil is null but landcover is valid. Add tests for both behaviors.
wenzeslaus
requested changes
Mar 5, 2026
wenzeslaus
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve dual hydrologic soil groups (A/D, B/D, C/D, D/D encoded as
11-14) to single groups based on drainage condition. Add -d flag to
select drained behavior (uses first group); default is undrained
(uses second group). Fall back to HSG D when soil is null but
landcover is valid. Add tests for both behaviors.