i.pr: modernize code and add doc files#1654
Open
nilason wants to merge 2 commits intoOSGeo:grass8from
Open
Conversation
- add parameters to function prototypes - make full use of G_fatal_error() and G_warning() (no need to sprintf the message to a buffer before) - update Makefiles to install with GRASS 8 g.extension - rename i.pr.features_selection parameter 'svm_C' to 'svm_c' - remove or comment out unused variables - PRLIB/test.c: re-define the macro SQR to an inline function, addressing -Wunsequenced compiler warning The sub-addons 'i.pr.training' and 'i.pr.statistics' are disabled for the time being due to use of GRASS 6 API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize
i.pr{.*}code and add doc files.This enables the installation of
i.prand all sub-addons (excepti.pr.trainingandi.pr.statistics). If, there wasn't for an issue withg.extension'sget_multi_addon_addons_which_install_only_html_man_page(), in particularly the regex, which doesn't handle the i.pr well and causes failure. That will need a fix of its own, I haven't found one yet though.The sub-addons
i.pr.trainingandi.pr.statisticsare disabled for the time being due to use of GRASS 6 API.