-
Notifications
You must be signed in to change notification settings - Fork 22
Brand synchronization #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I liked the previous font better or something similar to that sort of simpler letters (I do not know how they are called); this one does not seem to align with GRASS website style nor with the font in our logo. |
The font issues was a bug in the config should be fixed now. Will post an update screenshot when I'm at my computer. |
|
I've added the start to a style guide partially as a way to check edge cases. Set it up locally you need to add an The file should include the following PYTHONDEVMODE=1
QUARTO_PROFILE=localNow when you run quarto previewThen navigate to local site at
GRASS Quarto Design Guide |
petrasovaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I am not sure I understand the plan with the Team Documents and the guide.
Also, I thought we decided on sentence case for headings, no?
cwhite911
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petrasovaa thanks for the feedback. I've addressed your comments. My todo is to remove the _freeze files, and I'll add a section to show the language selection tabs.
veroandreo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn´t test locally as I need to update quarto and all. So, I marked typos mostly. Indeed, I also thought we agreed on sentence case for titles.
Fixed typos. Co-authored-by: Anna Petrasova <[email protected]> Co-authored-by: Veronica Andreo <[email protected]>
cwhite911
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know about the decision about title being sentence case. I will update the materials to reflect this.
Fixed typo Co-authored-by: Anna Petrasova <[email protected]>
…many edge cases, which would require list of words to ignore
|
@veroandreo and @petrasovaa I've addressed your comments please take another look when you are able. Design Guide PageHome PageTutorial Page |
|
It looks nice! I would hide the guide from the front page, it's not really a guide, it shows qmd syntax. Maybe we could make it into a contributing guide, or link it from README. |
|
BTW, there is some incosistency in headings - some of the headings (h2) are not bold in the screenshot, but they are bold when I render it locally. I like the bold ones. This needs to be corrected in the grass doc as well, they are not bold. |
The guide isn't visible at the moment when running in production (aka built by gh-actions) |








Synchronizing GRASS brand with Quarto
Updated PR Details
I've added a style guide partially as a way to check edge cases. Set it up locally you need to add an
_environment.localfile to the root of the project.The file should include the following
Now when you run
quarto previewthe content incontent/testswill render with the project.Then navigate to local site at
content/tests/styling.htmlhttp://localhost:5753/content/tests/styling.htmlGRASS Quarto Design Guide
Orginial Info
The formatting is close but still requires some additional tweaks.