Skip to content

Conversation

@josephlouise74
Copy link
Contributor

What is this PR for?

  • Just updating content and/or documentation
  • This fixes issue #_____
  • Spot fix (no issue #)
  • Merging WIP feature #_____
  • Merging done feature #_____
  • This is a merge from a version branch
  • Adding/Updating tests
  • This is a conflict resolution
  • This is a branch cleanup
  • Other: Add remote data support to SuggestInput

Summary

Added a new remote prop to the SuggestInput component.
This prop accepts a string URL (e.g. http://example.com/suggest) that returns an array of strings, which is then used to dynamically update the suggestion options.

This enhancement allows SuggestInput to fetch suggestions from a remote source, improving flexibility and usability for dynamic data scenarios.

I verify that...

  • I have logged my time in the commits
  • I have logged my time in this PR
  • I have tagged all the relevant issues (if applicable)
  • I am using VS Code for type checks and linting, or
  • I have ran npm run test with no errors
  • I have manually checked that the remote suggestions load and update correctly

…g url like http://example.com/suggest and this url should return an array of strings used to update the options.
…g url like http://example.com/suggest and this url should return an array of strings used to update the options.
…g url like http://example.com/suggest and this url should return an array of strings used to update the options.
@coveralls
Copy link

coveralls commented Jan 6, 2026

Pull Request Test Coverage Report for Build 20804631473

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 89.816%

Totals Coverage Status
Change from base Build 20513693629: -0.05%
Covered Lines: 2616
Relevant Lines: 2817

💛 - Coveralls

Copy link
Collaborator

@cblanquera cblanquera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing test and documentation update for this task. Also you need to add a fetch prop to allow dependency injection mainly for tests. Consider the following code.

const { 
   //...
   fetch: customFetch = fetch
   //...
} = props;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants