Merged
Conversation
1 task
Member
|
As per PR #230 (likely where this bug was introduced), its fine that |
Collaborator
Author
|
IAR as below so yes that's correct. Grand! I'll push the PR next week after the training
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@trevorb1 I filtered out the incorrect OAR entries (PWR Tech + INT Fuels). As a sense check I compared the OAR file from +- a year ago to the current one (after the bug fix) and there is still a difference. In the old OAR (left) the tech
MINCOAINDfeeds into the fuelCOAwhereas in the new OAR (right) this does not exist.Can you confirm whether this is correct/incorrect?
I suggest to merge this pull request late next week after the training sessions.