DocumentDB TF Enhancement new release#7
Open
yash-opstree wants to merge 1 commit intoOT-CLOUD-KIT:mainfrom
Open
DocumentDB TF Enhancement new release#7yash-opstree wants to merge 1 commit intoOT-CLOUD-KIT:mainfrom
yash-opstree wants to merge 1 commit intoOT-CLOUD-KIT:mainfrom
Conversation
| allow_major_version_upgrade = var.allow_major_version_upgrade | ||
| tags = var.tags | ||
| } | ||
| resource "aws_security_group" "docdb" { |
| description = "DB cluster parameter group" | ||
| family = var.cluster_family | ||
| resource "aws_docdb_cluster_parameter_group" "default" { | ||
| family = var.cluster_family |
There was a problem hiding this comment.
Could you please check naming module?
Module should have option to disable the standard name generation why the naming module.
| vpc_id = var.vpc_id | ||
| description = "Security group for DocumentDB cluster ${var.cluster_identifier}" | ||
|
|
||
| ingress { |
There was a problem hiding this comment.
This should not be part of the main.tf. It should be in the variables.tf as default value
| family = var.cluster_family | ||
| name = var.cluster_identifier | ||
|
|
||
| parameter { |
There was a problem hiding this comment.
It should go in the variables.tf as default value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Please find the updated tf module
Added "Enhanced Features" section with code examples
Better formatted code blocks
Added detailed security configurations
Improved usage examples with comments
Added contributor attribution for enhancements
Better organization of features and capabilities
More detailed documentation of security features
Clear demonstration of monitoring capabilities