Skip to content

Conversation

@tcxdgit
Copy link
Contributor

@tcxdgit tcxdgit commented Sep 9, 2025

Description
This PR addresses issue #1327 by adding support for configuring StatefulSet's podManagementPolicy in both Redis Cluster and Redis Sentinel clusters.

Previously, the operator didn't allow customization of the podManagementPolicy for StatefulSets, which restricted users from controlling pod creation/deletion order during scaling or updates. With this change, users can specify either OrderedReady (default) or Parallel pod management strategies based on their operational needs.

Fixes #1327

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

@codecov
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

❌ Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@66eaa2d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
api/rediscluster/v1beta2/zz_generated.deepcopy.go 0.00% 3 Missing and 1 partial ⚠️
.../redisreplication/v1beta2/zz_generated.deepcopy.go 0.00% 3 Missing and 1 partial ⚠️
api/redissentinel/v1beta2/zz_generated.deepcopy.go 0.00% 3 Missing and 1 partial ⚠️
internal/k8sutils/redis-cluster.go 0.00% 1 Missing and 1 partial ⚠️
internal/k8sutils/redis-replication.go 0.00% 1 Missing and 1 partial ⚠️
internal/k8sutils/redis-sentinel.go 0.00% 1 Missing and 1 partial ⚠️
internal/k8sutils/statefulset.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1525   +/-   ##
=======================================
  Coverage        ?   31.98%           
=======================================
  Files           ?       79           
  Lines           ?     5866           
  Branches        ?        0           
=======================================
  Hits            ?     1876           
  Misses          ?     3798           
  Partials        ?      192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tcxdgit tcxdgit changed the title feat:Add the ability to change the podManagementPolicy of the redis statefulset feat: Add the ability to change the podManagementPolicy of the redis statefulset Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the ability to change the "podManagementPolicy" of the redis statefulset

1 participant