-
-
Notifications
You must be signed in to change notification settings - Fork 322
fix: init-config container ignores imagePullPolicy from CRD #1611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: man4red <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1611 +/- ##
=======================================
Coverage ? 29.32%
=======================================
Files ? 83
Lines ? 6381
Branches ? 0
=======================================
Hits ? 1871
Misses ? 4314
Partials ? 196 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Does this value redisOperator.initContainerImageTag resolve your problem? |
positive |
|
I also wrote around 8k lines to fix more critical issues, but I couldn't group them into multiple PRs correctly. If this one took two weeks to review, the rest would probably take years |
Sorry for the late. |
Sorry, didn't mean to complain. I just need an advice on how to deal with it |
Small PR(and bugfix) will be got reviewed more quickly :) You could ping more reviewer for it |
I needed to check with our security/legal team first to confirm the correct process. Since the work was done during company time, I had to verify whether to submit these pull requests from my personal account or through the official company account |
Fix: init-config container ignores imagePullPolicy from CRD
Problem
Line 614 hardcodes
PullIfNotPresent, preventing users from forcing fresh image pulls. This breaks deployments when wrong image variant is cached (e.g., ARM64 node with cached AMD64 image → exec format error).Solution
Tests
TestInitConfigContainerImagePullPolicyTestInitConfigAndCustomInitContainerConsistency