Skip to content

Conversation

@man4red
Copy link

@man4red man4red commented Dec 4, 2025

Fix: init-config container ignores imagePullPolicy from CRD

Problem

Line 614 hardcodes PullIfNotPresent, preventing users from forcing fresh image pulls. This breaks deployments when wrong image variant is cached (e.g., ARM64 node with cached AMD64 image → exec format error).

Solution

-ImagePullPolicy: corev1.PullIfNotPresent,
+ImagePullPolicy: initcontainerParams.ImagePullPolicy,

Tests

  • TestInitConfigContainerImagePullPolicy
  • TestInitConfigAndCustomInitContainerConsistency

@man4red man4red changed the title Fix: init-config container ignores imagePullPolicy from CRD fix: init-config container ignores imagePullPolicy from CRD Dec 5, 2025
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@653320a). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1611   +/-   ##
=======================================
  Coverage        ?   29.32%           
=======================================
  Files           ?       83           
  Lines           ?     6381           
  Branches        ?        0           
=======================================
  Hits            ?     1871           
  Misses          ?     4314           
  Partials        ?      196           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@drivebyer drivebyer added the temp-fix These are temporary fix and need a proper fix later label Dec 16, 2025
@drivebyer
Copy link
Collaborator

drivebyer commented Dec 16, 2025

Does this value redisOperator.initContainerImageTag resolve your problem?

@man4red
Copy link
Author

man4red commented Dec 16, 2025

Does this value redisOperator.initContainerImageTag resolve your problem?

positive

@man4red
Copy link
Author

man4red commented Dec 16, 2025

I also wrote around 8k lines to fix more critical issues, but I couldn't group them into multiple PRs correctly. If this one took two weeks to review, the rest would probably take years

@drivebyer
Copy link
Collaborator

I also wrote around 8k lines to fix more critical issues, but I couldn't group them into multiple PRs correctly. If this one took two weeks to review, the rest would probably take years

Sorry for the late.

@man4red
Copy link
Author

man4red commented Dec 16, 2025

I also wrote around 8k lines to fix more critical issues, but I couldn't group them into multiple PRs correctly. If this one took two weeks to review, the rest would probably take years

Sorry for the late.

Sorry, didn't mean to complain. I just need an advice on how to deal with it

@drivebyer
Copy link
Collaborator

I also wrote around 8k lines to fix more critical issues, but I couldn't group them into multiple PRs correctly. If this one took two weeks to review, the rest would probably take years

Sorry for the late.

Sorry, didn't mean to complain. I just need an advice on how to deal with it

Small PR(and bugfix) will be got reviewed more quickly :) You could ping more reviewer for it

@man4red
Copy link
Author

man4red commented Dec 16, 2025

I also wrote around 8k lines to fix more critical issues, but I couldn't group them into multiple PRs correctly. If this one took two weeks to review, the rest would probably take years

Sorry for the late.

Sorry, didn't mean to complain. I just need an advice on how to deal with it

Small PR(and bugfix) will be got reviewed more quickly :) You could ping more reviewer for it

I needed to check with our security/legal team first to confirm the correct process. Since the work was done during company time, I had to verify whether to submit these pull requests from my personal account or through the official company account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

temp-fix These are temporary fix and need a proper fix later

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants