batch single shard slot assignment commands to avoid k8s api errors#1667
Open
JulianPaulus wants to merge 4 commits intoOT-CONTAINER-KIT:mainfrom
Open
batch single shard slot assignment commands to avoid k8s api errors#1667JulianPaulus wants to merge 4 commits intoOT-CONTAINER-KIT:mainfrom
JulianPaulus wants to merge 4 commits intoOT-CONTAINER-KIT:mainfrom
Conversation
fix: Extract struct to help properly order redis invocation The command passed to Redis must come after the flags. This struct allows for flags to be set after the command for redis is defined. Signed-off-by: Daniel Goldman <danielgoldman4@gmail.com>
JulianPaulus
requested review from
drivebyer,
iamabhishek-dubey and
shubham-cmyk
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously the operator ran one very large command when assigning slots to a single shard cluster. On some kubernetes distributions this could lead to http errors due to the pure size of the request. This PR aims to lessen the impact of this a bit by assigning slots in multiple batches.
Type of change
Checklist