Dockerfile can also build redis modules#103
Open
lilatomic wants to merge 6 commits intoOT-CONTAINER-KIT:masterfrom
Open
Dockerfile can also build redis modules#103lilatomic wants to merge 6 commits intoOT-CONTAINER-KIT:masterfrom
lilatomic wants to merge 6 commits intoOT-CONTAINER-KIT:masterfrom
Conversation
lilatomic
force-pushed
the
feature/modules
branch
from
89865b1 to
624d8da
Compare
drivebyer
requested changes
Dec 5, 2025
Dockerfile
Outdated
|
|
||
| COPY --from=builder /usr/local/bin/redis-server /usr/local/bin/redis-server | ||
| COPY --from=builder /usr/local/bin/redis-cli /usr/local/bin/redis-cli | ||
| COPY --from=builder /tmp/redis-stable/modules/*/*.so /modules/ |
Collaborator
There was a problem hiding this comment.
/tmp/redis-stable/modules//.so should like /tmp/redis-${VERSION}/modules//.so
|
@lilatomic are you planning to update as per review comments and submit? |
Author
|
ah, I missed this! I've made the change and am testing it now. |
Signed-off-by: Daniel Goldman <danielgoldman4@gmail.com>
specifically https://github.com/redis/docker-library-redis/blob/a13b78815d980881e57f15b9cf13cd2f26f3fab6/alpine/Dockerfile Signed-off-by: Daniel Goldman <danielgoldman4@gmail.com>
Signed-off-by: Daniel Goldman <danielgoldman4@gmail.com>
Signed-off-by: Daniel Goldman <danielgoldman4@gmail.com>
Signed-off-by: Daniel Goldman <danielgoldman4@gmail.com>
Redis > 8.2 wasn't building correctly. Initially I was hitting an error about `if let`: > `let` expressions in this position are unstable in the `wildcard` transitive dependency of redisearch. I upgraded the version of alpine used to get a more recent Rust toolchain which stabilised that syntax. This caused another error because the llvm-dev package dropped the `/usr/bin/llvm-config` binary, instead only including the binary with the version attached. (issue)[https://gitlab.alpinelinux.org/alpine/aports/-/work_items/17773]. The fix for that is in, but I wasn't getting it in the package archive. So I added a check that sets the correct envvar. Signed-off-by: Daniel Goldman <danielgoldman4@gmail.com>
lilatomic
force-pushed
the
feature/modules
branch
from
2c542e9 to
e6afdc5
Compare
Author
|
I hit some problems building the latest version of redis ("stable" is fine, 8.4 was not). I added the fixes in the last commit. You or I could drop/cherry-pick the commit if you'd rather that happen in a separate MR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redis includes several modules. The standard image does not include them.
This MR adds the capability for the Dockerfile to also build with modules. This allows for building images with or without the modules.
relates to OT-CONTAINER-KIT/redis-operator#1560