entrypoint.sh: compare major version number numerically for more robust version checking#105
Open
andreaswachs wants to merge 1 commit intoOT-CONTAINER-KIT:masterfrom
Conversation
andreaswachs
force-pushed
the
feature/better-version-checking-in-entrypoint
branch
from
4d81622 to
c8ca4d7
Compare
# Changes This makes a numerical comparison for the major version number when launching redis in cluster mode. This is to make sure that we don't end up in the first block after the if statement when running Redis newer than v7, as v8 is now out. Signed-off-by: Andreas Wachs <awa@corti.ai>
andreaswachs
force-pushed
the
feature/better-version-checking-in-entrypoint
branch
from
c8ca4d7 to
ebdcdc0
Compare
andreaswachs
changed the title
entrypoint.sh: compare major version number numerically for more robust version checking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This makes a numerical comparison for the major version number when launching redis in cluster mode.
This is to make sure that we don't end up in the first block after the if statement when running Redis newer than v7, as v8 is now out.