-
-
Notifications
You must be signed in to change notification settings - Fork 282
[WIP] Create form field for organization name and URL #4825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
… logo - Updated RegisterOrganizationView POST method with improved validation - Added URL existence checking using requests - Made logo required instead of optional - Improved error messages to be more specific and user-friendly - Added proper string trimming for input fields - Updated register_organization.html template - Moved logo section before optional fields - Created clear "Additional Information" section for optional fields - Made managers section truly optional - Added clarification in page header about required fields - Updated visual hierarchy to distinguish required from optional sections Co-authored-by: DonnieBLT <[email protected]>
- Added mock for URL validation requests.get call - Created test logo file using SimpleUploadedFile - Added logo to test data - Added assertion to verify logo was saved - Test now covers all required fields: name, URL, and logo Co-authored-by: DonnieBLT <[email protected]>
|
@copilot fix |
- Changed patch("requests.Response") to Mock() for proper mocking
- Added Mock import from unittest.mock
- Mock now correctly sets status_code attribute for URL validation test
Co-authored-by: DonnieBLT <[email protected]>
|
Hi @Copilot! This pull request has merge conflicts with the base branch that need to be resolved before it can be merged. To resolve the conflicts:
Once you push the resolved conflicts, this label and comment will be automatically updated. Thank you! 🙏 |
❌ Pre-commit checks failedThe pre-commit hooks found issues that need to be fixed. Please run the following commands locally to fix them: # Install pre-commit if you haven't already
pip install pre-commit
# Run pre-commit on all files
pre-commit run --all-files
# Or run pre-commit on staged files only
pre-commit runAfter running these commands, the pre-commit hooks will automatically fix most issues. 💡 Tip: You can set up pre-commit to run automatically on every commit by running: pre-commit installPre-commit outputFor more information, see the pre-commit documentation. |
Plan: Simplify Organization Registration Form
Based on the issue requirements, I need to create a simplified organization registration form that only requires:
Backend validation should check:
Implementation Checklist:
RegisterOrganizationViewPOST method to simplify validationregister_organization.htmltemplateOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.