-
Notifications
You must be signed in to change notification settings - Fork 4.3k
X-Frame-Options + browsers #1733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
* Remove deprecated X-Frame-Options * Clarify use of headers
|
Discussing in Slack. Main question is what the source is that the x-frame-options header is deprecated. |
|
According to CanIUse X-Frame-Options support has been consistent (not complete, but consistent) for years. |
|
https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/X-Frame-Options gives no indications that its depreciated. |
|
First of all, this is a REST API where the client is likely not a browser. I'd suggest to phrase that better in the cheat sheet. curl / java / php client etc do not care about those headers -- IMHO. @jmanico : Caniuse says The X-Frame-Options header has been obsoleted by the frame-ancestors directive from Content Security Policy Level 2. It's way more flexible, maybe deprecated was the wrong term. Given that and the fact we're talking about a REST API I believe it doesn't hurt to remove that line here. |
Good suggestion, clarifying that this is for web browsers is a good idea.
REST API's are frequently used for web clients. But this header is very legacy and we need to clarify the details as the OP suggests. I do not want to delete this but I do suggest we change with these two considerations:
Would these suggestions help satisfy your concerns, @drwetter ? |
|
@drwetter ping ;-) |
|
Sorry for letting this hang. And thanks for your persistence! My head is occupied with too much stuff. Like to get back latest on this in December during the first week. |
Please make sure that for your contribution:
[TEXT](URL)