-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Create Multi_Tenant_Security_Cheat_Sheet.md #1942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jmanico
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty beefy for a cheatsheet. Can I get others to review? cc @szh @mackowski
I think this is good quality, but my main concern is the length. I wonder if we can make this more of a "cheat" and more concise.
|
The reason it's so long is actually because of the code examples. I'm unsure too, but I thought code examples would be important for understanding. |
|
Agreed, it's not so long without the code samples. I think we have a way to make sections collapsible - maybe we can make the code samples collapsible so it's easier to read? |
szh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a fan. Great work @KadirArslan!
|
Hey, thank you for the valuable comment @szh |
szh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
mackowski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
|
Thanks @KadirArslan |
You're A Rockstar
@jmanico I mistakenly closed my previous PR and deleted my branch. So I've created new one with changes you suggested.
#1931
Please make sure that for your contribution:
[TEXT](URL)If your PR is related to an issue, please finish your PR text with the following line:
This PR fixes issue #1931 .
AI Tool Usage Disclosure (required for all PRs)
Please select one of the following options:
the contents and I affirm the results. The LLM used is
[llm name and version]and the prompt used is
[your prompt here]. [Feel free to add more details if needed]Thank you again for your contribution 😃