Refactoring Ip.py to return proper boolean values#1043
Merged
securestep9 merged 5 commits intoOWASP:masterfrom May 27, 2025
Merged
Refactoring Ip.py to return proper boolean values#1043securestep9 merged 5 commits intoOWASP:masterfrom
securestep9 merged 5 commits intoOWASP:masterfrom
Conversation
Collaborator
|
please don't mix the tests with core functionality refactoring in one PR. |
Contributor
Author
|
I'll keep this one only to refactoring the ip.py file to make it suitable for the tests. |
pUrGe12
changed the title
securestep9
approved these changes
May 27, 2025
pUrGe12
added a commit
to pUrGe12/Nettacker
that referenced
this pull request
Jun 3, 2025
* added bool to netaddr instances, removed redundant imports * created test file for ip.py * refactoring ip.py
pUrGe12
added a commit
to pUrGe12/Nettacker
that referenced
this pull request
Jun 9, 2025
* added bool to netaddr instances, removed redundant imports * created test file for ip.py * refactoring ip.py
pUrGe12
added a commit
to pUrGe12/Nettacker
that referenced
this pull request
Jun 10, 2025
* added bool to netaddr instances, removed redundant imports * created test file for ip.py * refactoring ip.py
pUrGe12
added a commit
to pUrGe12/Nettacker
that referenced
this pull request
Jun 12, 2025
* added bool to netaddr instances, removed redundant imports * created test file for ip.py * refactoring ip.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Currently the ip.py file has functions that are return boolean values to determine valid IP addresses. In functions like is_ipv4_range, its using
andwith netaddr.IPNetwork() which returns an IPNetwork object and not a boolean. This hasn't affected any functionality because its always being used asif is_ipv4_range(ip)which results in true as long as the function doesn't returnFalse, but for tests it will be necessary.Type of change
Checklist
make pre-commit, it didn't generate any changesmake test, all tests passed locally