-
-
Notifications
You must be signed in to change notification settings - Fork 927
DSL Integration #1153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rxerium
wants to merge
3
commits into
OWASP:master
Choose a base branch
from
rxerium:dsl-integration-oct25
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
DSL Integration #1153
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review the config structure documentation.
The implementation assumes a specific structure for
version_configwith keys like "patterns", "source", "expression", and "header". However, the YAML file uses "expressions" (plural) at line 54, not "expression" (singular) at line 101.At line 101, the code reads:
But the YAML at line 54-55 uses:
This mismatch means
dsl_expressionwill always be an empty string. You need to decide on singular vs plural and handle accordingly:🤖 Prompt for AI Agents
🧩 Analysis chain
Critical: Condition name mismatch between implementation and usage.
The code checks for
condition == "version_match"(line 96), but the YAML module at line 51 usesversion_dslas the condition key. This mismatch will cause the version matching feature to fail silently.Looking at the YAML file
nettacker/modules/vuln/aria_operations_cve_2025_41244.yamlat line 51, the condition is namedversion_dsl, but this code expectsversion_match. You need to align the naming:Option 1 (Recommended): Change the Python code to match the YAML:
Option 2: Change the YAML to use
version_matchinstead ofversion_dsl.Additionally, verify this alignment:
🏁 Script executed:
Length of output: 1345
Based on my verification of the codebase, the critical issue identified in the original review comment is confirmed: there is a definitive condition name mismatch that will cause the version matching feature to fail silently.
Critical: Condition name mismatch — YAML uses
version_dslbut Python code expectsversion_match.The search results confirm:
version_dslappears only in the YAML file at line 51 ofnettacker/modules/vuln/aria_operations_cve_2025_41244.yamlversion_matchappears in the Python condition handler at line 96 ofnettacker/core/lib/http.py, where the code checksif condition == "version_match""version_dsl", which will never match the string"version_match"in the comparisonThis mismatch causes the entire version matching feature to be silently skipped—no error is raised, the condition simply doesn't execute.
Fix: Change the YAML condition key from
version_dsltoversion_matchto align with the Python implementation:🤖 Prompt for AI Agents