-
-
Notifications
You must be signed in to change notification settings - Fork 41
First version of cloud suit #2001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@suvroc Thank you so much for this. This looks great. I was thinking, could we add the cards to the companion-cards-1.0-yaml file and the mapping to the companion-mappings-1.0.yaml? It may be that it's a good idea to have separate mapping files for the cloud suite, but we can keep it together with the other companion suites for now. |
|
Right, I will change it |
Changing "the attacker" to names
I fixed it |
|
@suvroc the signature on your commit is wrong. You can fix it by opening a new pull request and committing the changes through the website. |
Explaining CI terms
Is it better? I commit the change through WebUI |
|
@suvroc the last commit has a valid signature, but not the others. I’ll override the check and merge the changes. |
Thank you. |
cw-owasp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if "the cloud root or break-glass account" is a bit jargony. Would "an account with privileges" suffice?
Cloud Companion suit definition