Skip to content

Conversation

@suvroc
Copy link

@suvroc suvroc commented Jan 5, 2026

Cloud Companion suit definition

@suvroc suvroc requested review from cw-owasp and rewtd as code owners January 5, 2026 22:51
@sydseter
Copy link
Collaborator

sydseter commented Jan 6, 2026

@suvroc Thank you so much for this. This looks great. I was thinking, could we add the cards to the companion-cards-1.0-yaml file and the mapping to the companion-mappings-1.0.yaml?

It may be that it's a good idea to have separate mapping files for the cloud suite, but we can keep it together with the other companion suites for now.

@suvroc
Copy link
Author

suvroc commented Jan 6, 2026

Right, I will change it

Changing "the attacker" to names
@suvroc
Copy link
Author

suvroc commented Jan 6, 2026

@suvroc Thank you so much for this. This looks great. I was thinking, could we add the cards to the companion-cards-1.0-yaml file and the mapping to the companion-mappings-1.0.yaml?

It may be that it's a good idea to have separate mapping files for the cloud suite, but we can keep it together with the other companion suites for now.

I fixed it

cw-owasp
cw-owasp previously approved these changes Jan 7, 2026
@sydseter
Copy link
Collaborator

sydseter commented Jan 9, 2026

@suvroc the signature on your commit is wrong. You can fix it by opening a new pull request and committing the changes through the website.

@suvroc
Copy link
Author

suvroc commented Jan 9, 2026

@suvroc the signature on your commit is wrong. You can fix it by opening a new pull request and committing the changes through the website.

Is it better? I commit the change through WebUI

@sydseter
Copy link
Collaborator

sydseter commented Jan 9, 2026

@suvroc the last commit has a valid signature, but not the others. I’ll override the check and merge the changes.

@suvroc
Copy link
Author

suvroc commented Jan 9, 2026

@suvroc the last commit has a valid signature, but not the others. I’ll override the check and merge the changes.

Thank you.
I will do this properly for the next PR

@sydseter
Copy link
Collaborator

sydseter commented Jan 9, 2026

@rewtd , @cw-owasp: you’ll need to approve as I am not code owner.

@sydseter sydseter requested a review from cw-owasp January 9, 2026 21:12
Copy link
Collaborator

@cw-owasp cw-owasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if "the cloud root or break-glass account" is a bit jargony. Would "an account with privileges" suffice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants