-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Add lightbox and mark specific images as no-lightbox #3351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR integrates the MkDocs glightbox plugin and selectively disables lightbox behavior on certain images.
- Adds
mkdocs-glightbox
to the Python requirements and configures it inmkdocs.yml
. - Marks specific
<img>
elements withclass="no-lightbox"
to skip the lightbox effect.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
weaknesses/index.md | Add no-lightbox class to the overview image |
src/scripts/requirements.txt | Add mkdocs-glightbox==0.4.0 to dependencies |
mkdocs.yml | Enable glightbox plugin and configure skip_classes |
docs/index.md | Disable lightbox on site logo and partner logos |
docs/donate.md | Disable lightbox on donors image |
docs/contact.md | Disable lightbox on profile and logo images |
docs/checklists/index.md | Disable lightbox on checklist graphic |
Document/index.md | Disable lightbox on MASTG cover image |
Comments suppressed due to low confidence (3)
weaknesses/index.md:11
- Add an appropriate alt attribute (or alt="" if purely decorative) to this
<img>
element for screen-reader accessibility.
<img src="../assets/maswe-overview.png" style="width: 50%; border-radius: 5px; margin: 2em" class="no-lightbox"/>
docs/index.md:20
- This image is missing an alt attribute—please add meaningful alt text or alt="" if it’s decorative.
<img style="padding: 10px; max-width: 250px" src="assets/logo_circle.png" class="no-lightbox"/>
docs/contact.md:9
- Consider adding an alt attribute to this
<img>
so screen readers will skip or announce it appropriately.
<img src="../../assets/logo_circle.png" width="150px" style="margin-left: 4em; margin-top: 0em;" class="no-lightbox" align="right">
Co-authored-by: Carlos Holguera <[email protected]>
I deployed the site for testing on mobile. I like it, but I noticed a few issues:
|
Are you fine with these limitations, or do you want me to search for a different lightbox implementation? I can pretty easily implement the 1st item, which would solve nr3 as well? |
I'll think about it, let's discuss the options next week. The less hacky, the better. |
As a poc:
|
Closing since the files have moved. |
Add lightbox plugin
no-lightbox
Marked various images as no-lightbox