Skip to content

Conversation

sydseter
Copy link
Collaborator

This PR closes #3199

Description

Please see discussions under #3199


[x] I have read the contributing guidelines.

Guidelines for Pull Requests (you can delete this section after reading):

  • Please ensure that your content follows the style guide.
  • If you are working on Porting MASTG v1 Tests to v2, refer to this document.
  • If you are working on new MASWE, tests, or demos, refer to this document.

@sydseter
Copy link
Collaborator Author

Saw your comment about opening after merging. I’ll keep it closed for now.

@sydseter sydseter reopened this Jul 13, 2025
@sydseter
Copy link
Collaborator Author

This is currently in draft state awaiting #3199

@cpholguera
Copy link
Collaborator

Please pull the latest master and resolve any conflicts. Thanks!

@cpholguera cpholguera requested a review from TheDauntless July 17, 2025 05:44
@sydseter
Copy link
Collaborator Author

completly forgot about this one. I'll clean it up now and have a look at the comments on #3379

@cpholguera cpholguera requested a review from Copilot August 31, 2025 18:27
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the cryptography testing documentation to provide more comprehensive guidance on key derivation functions (KDFs) and improper random number generation. The changes expand the existing content with detailed explanations and best practices.

Key Changes:

  • Significantly expanded the "Improper Key Derivation Functions" section with detailed explanations of KDF types and use cases
  • Added comprehensive guidance on choosing appropriate KDFs for different scenarios (cryptographic vs password storage)
  • Enhanced the "Improper Random Number Generation" section with clearer explanations of CSPRNGs

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants