-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Port MASTG-TEST-0018 (Testing Biometric Authentication) to MASTG v2 #3560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…18 v2 port Co-authored-by: cpholguera <[email protected]>
Co-authored-by: cpholguera <[email protected]>
Co-authored-by: cpholguera <[email protected]>
Co-authored-by: cpholguera <[email protected]>
Co-authored-by: cpholguera <[email protected]>
|
@copilot Can you add another test with ID MASTG-TEST-0316 with "title: References to APIs Enforcing Authentication without Explicit User Action"? According to the documentation: https://developer.android.com/identity/sign-in/biometric-auth#no-explicit-user-action |
|
@copilot add another test with ID MASTG-TEST-0316 with "title: References to APIs Enforcing Authentication without Explicit User Action", according to the documentation: https://developer.android.com/identity/sign-in/biometric-auth#no-explicit-user-action |
Co-authored-by: cpholguera <[email protected]>
Co-authored-by: cpholguera <[email protected]>
Added MASTG-TEST-0316 "References to APIs Enforcing Authentication without Explicit User Action" with demo MASTG-DEMO-0077 and corresponding semgrep rule. The test checks for use of
Added MASTG-TEST-0316 "References to APIs Enforcing Authentication without Explicit User Action" with demo MASTG-DEMO-0077 and corresponding semgrep rule. The test checks for use of |
…Activity in MainActivity
|
@sushi2k This is the similar test from the MAS Reference App: https://github.com/Redguard/mas-reference-app/blob/main/android/app/src/main/java/org/masreferenceapp/auth/AuthBiometricPrompt.java It contains 3 tests:
This should be pretty much the same tests, right? The LLM-Version uses What if we use |
| @@ -0,0 +1,39 @@ | |||
| --- | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Duplicate MASTG-DEMO ID Detected
This file has the ID MASTG-DEMO-0082 which already exists in demos/android/MASVS-PLATFORM/MASTG-DEMO-0082/MASTG-DEMO-0082.md.
IMPORTANT: Please use the next available ID: MASTG-DEMO-0083
| @@ -0,0 +1,38 @@ | |||
| # Add KNOWLEDGE in Meta-data!!! | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Duplicate MASTG-TEST ID Detected
This file has the ID MASTG-TEST-0320 which already exists in tests-beta/android/MASVS-PLATFORM/MASTG-TEST-0320.md.
IMPORTANT: Please use the next available ID: MASTG-TEST-0321
Thanks @bernhste! I'll look into it, and then can maybe simply use your demo instead. To-Do:
|
|
@bernhste now I understand the difference. In this app I am using Claude was using the To-Do:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sushi2k Can it be that these tests also deprecate
https://mas.owasp.org/MASTG/tests/android/MASVS-AUTH/MASTG-TEST-0017/
And close #2951 ?
This PR closes #2952
Description
Ports the Android biometric authentication test (MASTG-TEST-0018) to v2 format, covering four MASWE weaknesses. Includes demos using BiometricPrompt API that highlight security considerations for biometric authentication.
New Tests (tests-beta/android/MASVS-AUTH/)
DEVICE_CREDENTIALorsetDeviceCredentialAllowed(true)authenticate()is called withoutCryptoObjectsetInvalidatedByBiometricEnrollment(false)setConfirmationRequired(false)New Demos
MASTG-DEMO-0076 - Demonstrates secure vs insecure
BiometricPromptconfigurations for device credential fallback:MASTG-DEMO-0077 - Demonstrates secure vs insecure configurations for explicit user confirmation:
New Semgrep Rules
mastg-android-biometric-device-credential-fallback.yml: FlagssetAllowedAuthenticatorswithDEVICE_CREDENTIALmastg-android-biometric-no-confirmation-required.yml: FlagssetConfirmationRequired(false)Deprecation
[x] I have read the contributing guidelines.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.