Skip to content

Get the GCP project_id for terratest from terraform.tfvars file#2072

Merged
bendehaan merged 1 commit intoOWASP:masterfrom
za:issue-2070-gcp-hardcode-project-id
Jun 24, 2025
Merged

Get the GCP project_id for terratest from terraform.tfvars file#2072
bendehaan merged 1 commit intoOWASP:masterfrom
za:issue-2070-gcp-hardcode-project-id

Conversation

@za
Copy link
Contributor

@za za commented Jun 24, 2025

Issue #2070

@za za requested review from bendehaan and commjoen as code owners June 24, 2025 10:11
Copy link
Collaborator

@bendehaan bendehaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again!

@bendehaan bendehaan merged commit 9ed5d34 into OWASP:master Jun 24, 2025
17 checks passed
@za
Copy link
Contributor Author

za commented Jun 25, 2025

Thanks for reviewing and merging it @bendehaan

I can see it's working now, after I set the project_id on terraform.tfvars:

$ go test -timeout 999999s

TestTerraformWrongSecretsGCP 2025-06-25T11:40:05+07:00 logger.go:67: ╵
TestTerraformWrongSecretsGCP 2025-06-25T11:40:05+07:00 logger.go:67:
TestTerraformWrongSecretsGCP 2025-06-25T11:40:05+07:00 logger.go:67: Destroy complete! Resources: 21 destroyed.
TestTerraformWrongSecretsGCP 2025-06-25T11:40:05+07:00 logger.go:67: 
PASS
ok      wrongsecrets    1283.974s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants