Fix Docker build pipeline matrix variable references in desktop-container-publish.yml#2229
Merged
Fix Docker build pipeline matrix variable references in desktop-container-publish.yml#2229
Conversation
Co-authored-by: commjoen <1457214+commjoen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] docker build pipelines are failing for master
Fix Docker build pipeline matrix variable references in desktop-container-publish.yml
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Docker build pipeline for desktop containers was failing with an invalid tag format error:
The root cause was incorrect matrix variable references in the
desktop-container-publish.ymlworkflow. The matrix is defined with acontainerkey containing an array of objects:However, the workflow was using
matrix.image_nameinstead ofmatrix.container.image_name, causing the variable to be undefined and resulting in malformed Docker tags likeghcr.io/owasp/wrongsecrets/:master.Changes made:
matrix.image_name→matrix.container.image_namematrix.dockerfile→matrix.container.dockerfilematrix.name→matrix.container.nameBefore:
ghcr.io/OWASP/wrongsecrets/+ undefined +:master→ghcr.io/owasp/wrongsecrets/:master❌After:
ghcr.io/OWASP/wrongsecrets/wrongsecrets-desktop:master✅The fix ensures proper Docker image naming for both the
wrongsecrets-desktopandwrongsecrets-desktop-k8scontainer variants.Fixes #2228.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.