Skip to content

Fix Docker build pipeline matrix variable references in desktop-container-publish.yml#2229

Merged
commjoen merged 2 commits intomasterfrom
copilot/fix-2228
Sep 3, 2025
Merged

Fix Docker build pipeline matrix variable references in desktop-container-publish.yml#2229
commjoen merged 2 commits intomasterfrom
copilot/fix-2228

Conversation

Copy link
Contributor

Copilot AI commented Sep 3, 2025

The Docker build pipeline for desktop containers was failing with an invalid tag format error:

ERROR: failed to build: invalid tag "ghcr.io/owasp/wrongsecrets/:master": invalid reference format

The root cause was incorrect matrix variable references in the desktop-container-publish.yml workflow. The matrix is defined with a container key containing an array of objects:

strategy:
  matrix:
    container:
      - name: "webdesktop"
        dockerfile: "Dockerfile_webdesktop"
        image_name: "wrongsecrets-desktop"
      - name: "webdesktop-k8s"
        dockerfile: "Dockerfile_webdesktopk8s"
        image_name: "wrongsecrets-desktop-k8s"

However, the workflow was using matrix.image_name instead of matrix.container.image_name, causing the variable to be undefined and resulting in malformed Docker tags like ghcr.io/owasp/wrongsecrets/:master.

Changes made:

  • Fixed matrix.image_namematrix.container.image_name
  • Fixed matrix.dockerfilematrix.container.dockerfile
  • Fixed matrix.namematrix.container.name

Before: ghcr.io/OWASP/wrongsecrets/ + undefined + :masterghcr.io/owasp/wrongsecrets/:master

After: ghcr.io/OWASP/wrongsecrets/wrongsecrets-desktop:master

The fix ensures proper Docker image naming for both the wrongsecrets-desktop and wrongsecrets-desktop-k8s container variants.

Fixes #2228.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: commjoen <1457214+commjoen@users.noreply.github.com>
Copilot AI changed the title [WIP] docker build pipelines are failing for master Fix Docker build pipeline matrix variable references in desktop-container-publish.yml Sep 3, 2025
Copilot AI requested a review from commjoen September 3, 2025 07:07
@commjoen commjoen marked this pull request as ready for review September 3, 2025 07:11
@commjoen commjoen requested a review from bendehaan as a code owner September 3, 2025 07:11
@commjoen commjoen merged commit ca8600f into master Sep 3, 2025
31 checks passed
@commjoen commjoen deleted the copilot/fix-2228 branch September 3, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docker build pipelines are failing for master

2 participants