Fixed MiniPlaceholders v3 compatibility #16
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The classes related to MiniMessage were also updated to a more native use of Adventure. This is because they will run exclusively in Paper environments, so there will be no problems on servers 1.21 or higher.
Owner
|
Thank you very much for making this PR, in general I am happy to merge the fix but would rather opt to keep the rest of the structure as is for now. Whilst ChatColorHandler is still supporting spigot I would prefer to depend on the spigot dependency instead of paper - just to ensure I can't accidentally introduce any potential incompatibility issues. The plan for the project in the future is to split it into separate gradle modules to clean the code base, with a similar effect to the changes in the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://miniplaceholders.github.io/docs/developer-guide/Integration#obtaining-placeholders