Skip to content

fix(terminalbench): stabilize background processes and simplify env loading#49

Merged
Octane0411 merged 1 commit intomainfrom
fix/terminalbench-bg-and-env
Mar 3, 2026
Merged

fix(terminalbench): stabilize background processes and simplify env loading#49
Octane0411 merged 1 commit intomainfrom
fix/terminalbench-bg-and-env

Conversation

@Octane0411
Copy link
Collaborator

Summary

  • make background Bash(run_in_background=true) processes survive CLI exit by using detached execution with file-backed stdout/stderr capture
  • keep BashOutput and KillBash compatible with detached process groups
  • avoid double-backgrounding by normalizing trailing & when run_in_background=true
  • force Harbor terminal-bench adapter to pass --cleanup-background never
  • simplify local env workflow back to a single .env source and remove profile scaffolding
  • update terminal-bench runbook with key/base_url sanity checks

Why

  • intermittent configure-git-webserver verifier failures (HTTP 000) were caused by background web services dying after parent process exit
  • env profile migration created a split workflow and frequent missing-key runs; this change restores one clear path

Validation

  • bun test packages/core/tests/tools/bash-enhanced.test.ts packages/core/tests/tools/bash-output.test.ts packages/core/tests/tools/kill-bash.test.ts
  • cd packages/core && bunx tsc --noEmit

Notes

  • local unrelated changes in packages/docs/public/icons/* were not included in this PR

@vercel
Copy link

vercel bot commented Mar 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
open-agent-sdk Ready Ready Preview, Comment Mar 3, 2026 8:19am

@Octane0411 Octane0411 merged commit b40598d into main Mar 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant