Skip to content

ci: optimize Docker build workflow and update actions#3437

Merged
KaloyanTanev merged 2 commits intoObolNetwork:mainfrom
DeVikingMark:prikol
Feb 4, 2025
Merged

ci: optimize Docker build workflow and update actions#3437
KaloyanTanev merged 2 commits intoObolNetwork:mainfrom
DeVikingMark:prikol

Conversation

@DeVikingMark
Copy link
Contributor

@DeVikingMark DeVikingMark commented Dec 30, 2024

Description of Changes

This PR improves the performance and reliability of the Docker image build workflow for promrated by:

  • Adding Docker layer caching
  • Updating all GitHub Actions to the latest stable versions
  • Fixing a typo in the workflow name
  • Modernizing deprecated command syntax

Details of Changes

  • Added actions/cache@v3 for Docker layer caching
  • Updated versions of actions:
    • actions/checkout@v3v4
    • docker/setup-qemu-action@v1v3
    • docker/setup-buildx-action@v1v3
    • docker/metadata-action@v3v5
    • docker/build-push-action@v4v5
    • peter-evans/repository-dispatch@v2v3
  • Replaced deprecated set-output syntax with GITHUB_OUTPUT
  • Fixed typo "Deply" → "Deploy" in the workflow name

Performance Impact

  • Docker layer caching will significantly speed up subsequent builds
  • Using the latest versions of actions ensures better performance and security

Testing

  • Workflow runs successfully
  • Docker image builds and publishes correctly
  • Caching works between builds

category: misc
ticket: none

@sonarqubecloud
Copy link

Copy link
Collaborator

@apham0001 apham0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apham0001 apham0001 added merge when ready Indicates bulldozer bot may merge when all checks pass cicd labels Jan 23, 2025
@apham0001 apham0001 changed the title ci: Optimize Docker build workflow and update actions to latest versions ci: Optimize Docker build workflow and update actions Jan 23, 2025
@KaloyanTanev
Copy link
Collaborator

@DeVikingMark can you rebase your PR on top of the main branch? After that we'll merge it :).

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2025

@KaloyanTanev KaloyanTanev changed the title ci: Optimize Docker build workflow and update actions ci: optimize Docker build workflow and update actions Feb 4, 2025
@KaloyanTanev KaloyanTanev added merge when ready Indicates bulldozer bot may merge when all checks pass and removed merge when ready Indicates bulldozer bot may merge when all checks pass labels Feb 4, 2025
@KaloyanTanev KaloyanTanev merged commit 55769e0 into ObolNetwork:main Feb 4, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cicd merge when ready Indicates bulldozer bot may merge when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants