*: lock supporting grace period #4226
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4226 +/- ##
==========================================
+ Coverage 56.96% 57.01% +0.05%
==========================================
Files 237 237
Lines 30688 30721 +33
==========================================
+ Hits 17482 17517 +35
+ Misses 10976 10974 -2
Partials 2230 2230 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
KaloyanTanev
approved these changes
Jan 16, 2026
| // New returns new private key locking service. It errors if a recently-updated private key lock file exists. | ||
| func New(path, command string) (Service, error) { | ||
| content, err := os.ReadFile(path) | ||
| func New(privKeyFilePath, clusterLockFilePath, command string) (Service, error) { |
Collaborator
There was a problem hiding this comment.
nitpick: can we rename that to privKeyFileLockPath? Reading it as privKeyFilePath I've assumed it's the actual privKey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cluster lock hash validation to privkey lock file
Enhances the private key lock mechanism to prevent race conditions during cluster configuration changes.
Changes
cluster_lock_hashin the privkey lock file metadataprivkeylock.New()signature to accept cluster lock file pathWhy
After cluster edits (adding/removing operators), validators shouldn't immediately start with the new configuration. The grace period ensures:
category: feature
ticket: #4200