fix: fix is_in_apt function for virtual packages#41
Merged
foosel merged 1 commit intoOctoPrint:mainfrom Jun 16, 2025
Merged
Conversation
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Member
|
Frankly, that solution of yours also strikes me as the cleaner way to get this info 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix the is_in_apt function for virtual packages. For example
policykit-1doesn't exist anymore in Debian Trixie and the output ofapt-cache policy policykit-1is:This output creates a false positive with the old
is_in_aptlike here: https://github.com/meteyou/MainsailOS-dev/actions/runs/15515686418/job/43682280429#step:13:195Here is a test run with the new
is_in_apt: https://github.com/meteyou/MainsailOS-dev/actions/runs/15516654843/job/43684788202#step:13:206An alternative version would be to parse the
Candidateoutput if it is !=(none)