-
Notifications
You must be signed in to change notification settings - Fork 2
Add all temperatures to websocket for future use #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add tools if you have more set in the printer profile - Add a few variants for chamber like cavity (jneilii firmware uses it) - Add TMC2240 temperatures, since most TMCs do not support temp, limit to list (temps do not show unless the driver is energizes, so add `or 0` since it will return None when it's not energized. I'm not sure what others drivers should be added so I only added 2240, but it's easy to add to it.
…w way to tell the connector that a new list of temperatures names is available
…isable based on state?
82d192f to
fa45d54
Compare
|
|
||
| self.btnKlipperRestartClick = function() { | ||
| showConfirmationDialog({ | ||
| message: gettext("<strong>This will restart the Klipper service.</strong></p><p>This might disrupt any ongoing operations related to Klipper."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gettext should not include html whatsoever I'm pretty sure, it would interfere with the ability to translate I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100% agree I missed that, thanks I’ll fix it tomorrow when I keep trying to solve my other issues ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be solved in 2e447bb
Still not used to having 2 accounts :\
…ich isn't usable when connecting
or 0since it will return None when it's not energized. I'm not sure what others drivers should be added so I only added 2240, but it's easy to add to it.NOTES:
TODO:
FIRMWARE_RESTARTorRESTARTit rereads and rebuilds as the sensor could have changed, haven't tested this yet to make sure. The both lists might need to be reset when system firmware is triggered?gcode_idparameter, this indicated to KlipperScreen and other UIs to graph/display that temp, maybe we can find a way to only get those, sadly that value wasn't present in the object query.FIRMWARE_RESTARTorRESTART(uses moonraker post instead of WS, incase WS isn't ready)FUTURE PRs:
gcodesbut this value can be changed in the klipper config, we might want to see if we can get the value, I haven't checked the moon raker api to see if it's fetch able yet, but wanted to log it.MAYBE AN OTHER PLUGIN??