Remove .NET Framework as a target framework #1669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APErebus
changed the title
APErebus
force-pushed
the
ap/remove-netfx
branch
from
e8ecd9e to
71908d1
Compare
APErebus
commented
Jan 12, 2026
| <RuntimeIdentifiers>win-x64;linux-x64;osx-x64;linux-arm;linux-arm64</RuntimeIdentifiers> | ||
| <LangVersion>8.0</LangVersion> | ||
| <TargetFramework>net8.0</TargetFramework> | ||
| <RuntimeIdentifiers>win-x64</RuntimeIdentifiers> |
Contributor
Author
There was a problem hiding this comment.
This project is only build for windows. I'm not sure why this has all the other runtime identifiers?
Jtango18
reviewed
Jan 14, 2026
Jtango18
reviewed
Jan 14, 2026
source/Calamari.Tests/Fixtures/Integration/Proxies/WebProxyInitializerFixture.cs
Show resolved
Hide resolved
Jtango18
approved these changes
Jan 14, 2026
Contributor
Jtango18
left a comment
Jtango18
left a comment
There was a problem hiding this comment.
Couple of comments/questions but other wise - neatl clean, fast, WOMM - Ship It!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer build for .NET Framework 4.6.2 for all projects in the Calamari solution
Projects now only target .NET 8.0 or .NET Standard and have a
LangVersionset todefault.I also removed a few obvious pre-processor sections that were specifically defined for .NET Framework.
After merging, there will need to be changes to the TeamCity project to remove the .NET Framework specific testing.
The build process has been cleaned up a bit where
Calamariis now not treated any differently that the rest of the process, it's just built the same way as the old cross-platform "flavours".ref MD-1409