Merged
Conversation
zentron
commented
Feb 5, 2026
| var serviceMessages = log.Messages.GetServiceMessagesOfType("setVariable"); | ||
| serviceMessages.GetPropertyValue("ArgoCD.GatewayIds").Should().Be(GatewayId); | ||
| serviceMessages.GetPropertyValue("ArgoCD.GitUris").Should().Be(updated ? new Uri(OriginPath).AbsoluteUri : string.Empty); | ||
| serviceMessages.GetPropertyValue("ArgoCD.GitUris").Should().Be(updated ? OriginPath : string.Empty); |
Contributor
Author
There was a problem hiding this comment.
With the changes, we are expecting to echo out the actual original repo urls, not a converted one.
zentron
commented
Feb 5, 2026
| public HelmValuesFileImageUpdateTarget(ApplicationName appName, | ||
| ApplicationSourceName sourceName, | ||
| string defaultClusterRegistry, | ||
| public HelmValuesFileImageUpdateTarget(string defaultClusterRegistry, |
Contributor
Author
There was a problem hiding this comment.
Side journey, I couldn't find these properties used anywhere
zentron
force-pushed
the
robe/sshargo2
branch
from
e7cdc09 to
786ccfa
Compare
Update calamari argo step to convert git scp to https
zentron
force-pushed
the
robe/sshargo2
branch
from
786ccfa to
7c7b278
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Octopus doesn't currently support SSH credentials for git. It is not uncommon however for customers to have their existing argued installations using ssh. This change maps ssh configurations (if provided) in an argued repository source to a HTTPS uri which can then be matched against the existing Git Credential allow-listing.
Additional related change in Octopus Server https://github.com/OctopusDeploy/OctopusDeploy/pull/40148