Merge change allowing parameters files to be handled properly.#1764
Merged
Merge change allowing parameters files to be handled properly.#1764
Conversation
| ? templateService.GetSubstitutedTemplateContent(templateParametersFile, filesInPackageOrRepository, context.Variables) | ||
| : null; | ||
|
|
||
| var parameters = templateService.GetSubstitutedTemplateContent("parameters.json", inPackage: false, context.Variables); |
There was a problem hiding this comment.
This is the key change: Bicep template step doesn't support parameters sourced from package or Git repository.
zentron
approved these changes
Feb 9, 2026
Contributor
zentron
left a comment
zentron
left a comment
There was a problem hiding this comment.
Just so I understand,
in SPF the parameters files cannot come from a package, so this change ensures that behaviour.
Any reason it shouldnt be extended to support this behaviour for consistency?
Contributor
Author
|
@zentron it probably should, but we will need to resolve a larger Package source issue first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes changes (originally authored by @denys-octopus ) to allow handling of Parameters files for Bicep templates to be handled in a way that is consistent with the Step Package Framework implementation it is replacing.