Skip to content

Comments

WIP handle package and git source bicep templates#1768

Closed
scme0 wants to merge 4 commits intomainfrom
scme/bicep-extract-package
Closed

WIP handle package and git source bicep templates#1768
scme0 wants to merge 4 commits intomainfrom
scme/bicep-extract-package

Conversation

@scme0
Copy link
Collaborator

@scme0 scme0 commented Feb 10, 2026

⚠️ Does this change require a corresponding Server Change?
⚠️ If so - please add a "Requires Server Change" label to this PR!

readonly IExtractPackage extractPackage;

public DeployBicepTemplateBehaviour(ICommandLineRunner commandLineRunner, TemplateService templateService, AzureResourceGroupOperator resourceGroupOperator, ILog log)
public DeployBicepTemplateBehaviour(ICommandLineRunner commandLineRunner, TemplateService templateService, AzureResourceGroupOperator resourceGroupOperator, ICalamariFileSystem fileSystem, IExtractPackage extractPackage, ILog log)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a ExtractPackage virtual method on the DeployAzureBicepTemplateCommand base class.
Is it possible to perform the package extraction for the bicep step in an implementation of this method, leaving the deployment behaviour to be agnostic about packages and extraction?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for this, I didn't realise this infrastructure was there. In the end I figured out a way to make this work without changing any Calamari code at all. Server changes are here: https://github.com/OctopusDeploy/OctopusDeploy/pull/40299

@scme0
Copy link
Collaborator Author

scme0 commented Feb 12, 2026

Closing because changes to Calamari are no longer required for this change. See Server change: https://github.com/OctopusDeploy/OctopusDeploy/pull/40299

@scme0 scme0 closed this Feb 12, 2026
@scme0 scme0 deleted the scme/bicep-extract-package branch February 12, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants