[on hold] [pending api work] Notification settings#1186
Open
rafael-xmr wants to merge 3 commits intomasterfrom
Open
[on hold] [pending api work] Notification settings#1186rafael-xmr wants to merge 3 commits intomasterfrom
rafael-xmr wants to merge 3 commits intomasterfrom
Conversation
rafael-xmr
force-pushed
the
notification-settings
branch
from
35b3dc5 to
5ac7395
Compare
ui/redux/actions/notifications.js
Outdated
Comment on lines
+227
to
+228
| channel_id: '*', | ||
| channel_name: '*', |
Contributor
There was a problem hiding this comment.
I see a channel selector, but the ID is always the same -- what's the function of the selector?
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
infinite-persistence
left a comment
infinite-persistence
left a comment
There was a problem hiding this comment.
Nice and clean, as always 👍
Just a couple of minor suggestions, and a 405 error mentioned above.
rafael-xmr
force-pushed
the
notification-settings
branch
from
5ac7395 to
e75a3f3
Compare
Contributor
Author
Contributor
|
I think the build failed, or didn't capture the latest commit (not seeing the new |
Contributor
Author
|
Sorry! now it should be |
tzarebczan
changed the title
tzarebczan
changed the title
tzarebczan
changed the title
tzarebczan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Issue Number: closes #615