-
Notifications
You must be signed in to change notification settings - Fork 78
Sync steps #3417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+13
−3
Merged
Sync steps #3417
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0e3264f
updated sync links/ FAQ
ceoger 8f56a3f
Merge branch 'master' of https://github.com/OdyseeTeam/odysee-frontend
ceoger 6f5973f
improve sync instructions
ceoger cfa28a7
adding new changes to a branch
ceoger 77cbe51
improved sync steps
ceoger 1d07c48
updated sync faq links
ceoger b5896cf
updated sync links
ceoger faf22f7
updated sync links
ceoger 6c774ed
Merge branch 'OdyseeTeam:master' into sync-steps
ceoger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
do trailing slashes after url fragment anchor identifiers affect browser navigation💡 Result:
Yes—anything after the first
#is part of the fragment identifier, and it runs to the end of the URL, so a trailing slash is not ignored; it changes the fragment value. The/character is explicitly allowed inside a fragment. [1]Browsers scroll to an in-page target by decoding the fragment and looking for an element whose
idexactly equals that decoded fragment (and historically, an<a name="...">). So#sectionand#section/are different:#section/will only scroll if the page contains an element withid="section/". Otherwise, the navigation won’t jump to the intended anchor. [3][4]Separately, the fragment is a client-side concept (exposed as
location.hash/URL.hash), so changing#sectionto#section/also changes what client-side routers (hash-based SPAs) see and may change their routing behavior. [2]Sources: [1] RFC 3986, Fragment Identifier rules • [2] MDN
URL.hash• [3] WICG “scroll-to-text-fragment” (patching HTML fragment scrolling; includes “find a potential indicated element” algorithm) • [4] W3C HTML5 spec (id matching is exact)Remove trailing slash from URL fragment—it prevents anchor navigation.
The fragment identifier
#requirements/won't match an element withid="requirements"on the target page. Browsers perform exact matching, so the trailing slash changes the fragment value. Remove it to ensure the anchor scrolls to the intended section.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents