Conversation
fionnachan
approved these changes
Apr 29, 2025
Member
fionnachan
left a comment
fionnachan
left a comment
There was a problem hiding this comment.
tested and LGTM, can you run yarn generate on this PR or after this is merged? I see some very minor changes in the generated files
another thing to note: arbOwnerPublicABI changes quite a bit on Arb Sepolia, so if we want to keep old version support we need versioning
spsjvc
added a commit
that referenced
this pull request
May 9, 2025
spsjvc
added a commit
that referenced
this pull request
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes FS-1240.
https://docs.etherscan.io/etherscan-v2