Merged
Conversation
dewanshparashar
approved these changes
May 16, 2025
fionnachan
reviewed
May 16, 2025
Comment on lines
+67
to
+71
| reviewers: | ||
| - 'OffchainLabs/full-stack' | ||
| labels: | ||
| - 'dependencies' | ||
| - 'external' |
Member
There was a problem hiding this comment.
since we have disabled opening PRs for external deps, i don't think we need these?
Contributor
Author
There was a problem hiding this comment.
it should still open a PR for security issues
.github/dependabot.yml
Outdated
| # === Root package.json (/) === | ||
| # Internal dependencies | ||
| - package-ecosystem: 'npm' | ||
| directory: '/' |
Member
There was a problem hiding this comment.
can't you use directories instead and remove the duplicate?
Contributor
Author
There was a problem hiding this comment.
oooohh awesome. I didn't see that option.
also:
The directories key supports globbing and the wildcard character *
that will be useful for other projects too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.