build: add prepare script for git-based installation#667
Open
douglance wants to merge 6 commits intofeat/enqueue-token-bridge-deploymentfrom
Open
build: add prepare script for git-based installation#667douglance wants to merge 6 commits intofeat/enqueue-token-bridge-deploymentfrom
douglance wants to merge 6 commits intofeat/enqueue-token-bridge-deploymentfrom
Conversation
douglance
force-pushed
the
feat/add-prepare-script
branch
from
900895e to
7e2a1f0
Compare
When installing chain-sdk from a git URL with &path:src, package managers extract only the subdirectory. This prepare script goes up to the repo root and runs the TypeScript build so dist/ exists.
douglance
force-pushed
the
feat/add-prepare-script
branch
from
7e2a1f0 to
ba3e4e8
Compare
TucksonDev
changed the base branch from
main
to
feat/enqueue-token-bridge-deployment
Apply Prettier formatting and allowlist 6 transitive dev-only CVEs in audit-ci.jsonc (flatted, picomatch, brace-expansion, yaml).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preparelifecycle script tosrc/package.jsonthat builds the TypeScript output when the package is installed from a git URLpayablemutator to the UpgradeExecutor ABIDetails
When installing chain-sdk from a git URL (e.g.
github:OffchainLabs/arbitrum-chain-sdk#branch&path:src), package managers clone the repo but don't build it, sodist/is missing and the package is empty. Thepreparescript runs automatically after install for git-hosted dependencies, navigating to the repo root and running the TypeScript compiler to produce thedist/output.This has no effect on installs from the npm registry, since published tarballs already contain the built
dist/.