fix(batch-poster): surface AnyTrust decode errors and add Espresso ABI#95
Open
fix(batch-poster): surface AnyTrust decode errors and add Espresso ABI#95
Conversation
The AnyTrust DACert check silently swallowed decode errors for chains using non-standard batch poster functions (e.g. Espresso). This meant unknown selectors like 0x37501551 were logged to console but never reported to Slack, masking potential issues. - Add Espresso 7-param addSequencerL2BatchFromOrigin variant to sequencerInboxAbi so DACert verification works for Espresso chains - Push decode errors to the alerts array instead of only logging them, so unrecognized selectors are surfaced to Slack - Add tests for Espresso DACert decoding and decode-failure alerting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AnyTrust DACert check silently swallowed decode errors for chains using non-standard batch poster functions (e.g. Espresso). This meant unknown selectors like 0x37501551 were logged to console but never reported to Slack, masking potential issues.