core: Multi-fragment activation: charge gas per fragment#619
Closed
core: Multi-fragment activation: charge gas per fragment#619
Conversation
KolbyML
changed the title
pmikolajczyk41
approved these changes
Feb 4, 2026
Comment on lines
+82
to
88
| // ToWordSize returns the ceiled word size required for memory expansion. | ||
| func ToWordSize(size uint64) uint64 { | ||
| return toWordSize(size) | ||
| } | ||
|
|
||
| // toWordSize returns the ceiled word size required for memory expansion. | ||
| func toWordSize(size uint64) uint64 { |
Member
There was a problem hiding this comment.
why not making the old function public? fork-diff-wise I'd say it wouldn't be that harmful
Member
Author
There was a problem hiding this comment.
Idk I just felt like avoiding modifying go-ethereum code might make merging the upstream work easier
MishkaRogachev
approved these changes
Feb 4, 2026
Member
Author
|
no longer needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes NIT-4405
pulled in by OffchainLabs/nitro#4312