Conversation
Co-authored-by: Lee Bousfield <ljbousfield@gmail.com> Co-authored-by: Chris Buckland <cpbuckland88@gmail.com> Co-authored-by: shotaro <shawtarohgn@gmail.com> Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com>
This reverts commit 8269b1a.
Co-authored-by: Chris Buckland <cpbuckland88@gmail.com> Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com>
Co-authored-by: gzeon <im@gzeon.dev>
* chore: effectively disableing delay buffer * chore: typo Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com> --------- Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com>
* refactor: move hardcoded value to config * refactor: minimumAssertionPeriod and validatorAfkBlocks in bold upgrade setting * perf: remove onchain verification * chore: update sigs * refactor: remove hardcode in rollup initialize * chore: update example * test: new config param * fix: format test * test: fix config * Apply suggestions from code review Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com> --------- Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com>
* docs: add note regarding reorg * wip: use create2 * edit comment * start over * use create2 in bridge creator * require rollup exists * fix tests * fix lint * Revert "docs: add note regarding reorg" This reverts commit d451b72. * remove unnecessary args from salt * fmt * put the salt args back * refactor: move hardcoded value to config * refactor: minimumAssertionPeriod and validatorAfkBlocks in bold upgrade setting * perf: remove onchain verification * chore: update sigs * refactor: remove hardcode in rollup initialize * chore: update example * test: new config param * fix: format * fix: BridgeTemplates * fix: memory * fix: format test * feat: use msg.data hash as salt * test: fix * test: fix config * fix: slither * refactor: bridge creator create2Salt * chore: remove unintended change * chore: slither --------- Co-authored-by: gzeon <im@gzeon.dev> Co-authored-by: gzeon <hng@offchainlabs.com>
* update links in README.md * update link in README.md update link to deployed nitro contract addresses * adding #core-contracts to end of link text --------- Co-authored-by: gzeon <h@arry.io>
test: improve coverage
yahgwai
approved these changes
Jan 7, 2025
| @@ -2,7 +2,7 @@ | |||
| ╭----------------------------------+------------------------------------------------+------+--------+-------+------------------------------╮ | |||
| | Name | Type | Slot | Offset | Bytes | Contract | | |||
| +==========================================================================================================================================+ | |||
| | _initialized | bool | 0 | 0 | 1 | src/bridge/Bridge.sol:Bridge | | |||
| | _initialized | uint8 | 0 | 0 | 1 | src/bridge/Bridge.sol:Bridge | | |||
Collaborator
There was a problem hiding this comment.
In the release notes we mention a guide for dealing with storage changes but we should also include a link to that guide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.