Skip to content

Comments

Decimals patch version - v2.1.2#292

Merged
gzeoneth merged 8 commits intov2.1.1-branchfrom
decimals-patch-version
Feb 5, 2025
Merged

Decimals patch version - v2.1.2#292
gzeoneth merged 8 commits intov2.1.1-branchfrom
decimals-patch-version

Conversation

@yahgwai
Copy link
Collaborator

@yahgwai yahgwai commented Jan 25, 2025

No description provided.

@cla-bot cla-bot bot added the s label Jan 25, 2025
@yahgwai yahgwai changed the title Decimals patch version - v2.1.2 WIP - Decimals patch version - v2.1.2 Jan 25, 2025
@yahgwai yahgwai force-pushed the decimals-patch-version branch 2 times, most recently from 8ae825f to 275ba6c Compare January 25, 2025 16:32
@yahgwai yahgwai changed the base branch from v2.1.1-branch to foundry-v0.3.0 January 25, 2025 16:37
@gzeoneth
Copy link
Member

gzeoneth commented Feb 4, 2025

let's merge #293 first

Copy link
Member

@gzeoneth gzeoneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from foundry-v0.3.0 to v2.1.1-branch February 5, 2025 12:08
@yahgwai yahgwai changed the title WIP - Decimals patch version - v2.1.2 Decimals patch version - v2.1.2 Feb 5, 2025
@yahgwai yahgwai marked this pull request as ready for review February 5, 2025 12:09
@gzeoneth gzeoneth merged commit f843905 into v2.1.1-branch Feb 5, 2025
10 of 12 checks passed
@gzeoneth gzeoneth deleted the decimals-patch-version branch February 5, 2025 14:52
Sneh1999 added a commit to EspressoSystems/nitro-contracts that referenced this pull request Mar 11, 2025
* Added express lane auction contracts draft

* Add script that gets metadata hashses for selected contracts

* Updated express lane interface and added more tests

* Addressed more todos

* Renamed auctioneer to auction clerk

* Updates from spec

* Balance2 usage and addressed more todos

* Updated to safeTransfer

* Fixed strick equality

* Added testing comments

* Formatting

* Added slither exceptions

* Test updates and internal lib function

* Added resolvedRounds public and set latestResolvedRound internal

* Use access control enumerable

* Use functions internally, make others external

* Formatting

* Dont reset withdrawal round after finalized withdrawal - just on deposit

* Added domain comment

* Added domain value to express lane auction

* Added todos based on code review

* Docs updates

* Beginnings of separate balance testing

* Finished balance tests

* Added elc round specific tests

* Docs and testing for resolved rounds

* Cleaned todos in testing file

* Addressed more todos

* Formatting

* Slither updates

* Added transferrer setting first draft

* Updates from slither mutate

* Set transferrer into interface

* Added alternative transferors and tests

* Comment update

* Removed todo

* chore: verification improvements

* Added round timing setter

* Remove comment

* Removed unneeded admin roles

* Removed struct params usage

* Delete todo

* chore: change rinkeby to holesky

* chore: max data size warning

* refactor: use _isRunningOnArbitrum

* chore: additional logging

* Added 712 signing

* Formatting and test update

* Reset to main branch and updated audit ci

* Try matrix audit versions

* Try v4

* Use raw restore

* Use github restore branch

* ci: remove restore node modules action

* update cache key

* Add option to enable CacheManager through UpgradeExecutor

* Use arb owner public to poll for chain owners

* Update natspec

* Update audit-ci.json

* fix: lint

* ci: upload 4bytes

* ci: move upload 4bytes to later step

* ci: only show non dupe 4bytes uploaded

* chore: make upload-4bytes yarn action

* chore: rename to test:update

* chore: ignore axios audit issue

* ci: try fix 4844 test

* Revert "ci: try fix 4844 test"

This reverts commit 1e8d6f5.

* Updated NotTransferor address to match NotExpressLaneController

* Formatting

* Added bid const hash

* Comment update

* test: fix

* Factor out round timing interval interanl

* Refactored the round timing info setting to use shared internal func

* CR updates

* More updates from CR

* Update src/express-lane-auction/ExpressLaneAuction.sol

Co-authored-by: gzeon <hng@offchainlabs.com>

* Updated shadow variable name

* Added int offset

* feat: check integrity before outputing metadata hashes

* Updated round timing tests

* Updated comment

* Updated comments

* Updates from goran's cr

* Slither update

* Formatting

* Removed set beneficiary

* Updated comment

* Public to external

Co-authored-by: gzeon <hng@offchainlabs.com>

* Added balance at round functions

* Added specific boundary conditions for balance test as fuzzing seemed to be missing 1 case

* Removed out of date comment

* Balance updates from audit review

* minor typo fixes in comments

* Added a burner contract in case the dao decides to burn the funds instead of collecting

* Burner tests

* Added comment

* Comment update

* ci: remove 4844 testnode ref (OffchainLabs#241)

* ci: remove 4844 testnode ref

* ci: use more recent goomy-blob

* ci: fix tag

* fix: whitelist yarn audit issue

* Fix ArbWASM precompile minInitGas() method return types

* Revert "Fix ArbWASM precompile minInitGas() method return types"

* Wait for the deployment of upgrade executor (OffchainLabs#219)

Co-authored-by: gzeon <hng@offchainlabs.com>

* docs: explain arbOSVersion offset (OffchainLabs#245)

* arbwasm: fix mininitgas return types

* Fix typo in license (OffchainLabs#254)

* fix: orbit e2e (OffchainLabs#257)

Co-authored-by: Chris Buckland <cpbuckland88@gmail.com>

* test: Add contracts for HostIO gas tests (OffchainLabs#255)

* chore: format

* Revert "chore: format"

This reverts commit 738c3dc.

* v2.1.1-beta.0

* chore: ex lane deploy (OffchainLabs#267)

* v2.1.1

* Storage file updates

* Use stable foundry

* v2.1.2 (OffchainLabs#292)

* set decimals in postUpgradeInit

* more intentional function name

* comment

* call it postUpgradeInit

* add zero check

* Added post upgrade init sig

* chore: v2.1.2

---------

Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com>
Co-authored-by: gzeon <im@gzeon.dev>

* v2.1.3 (OffchainLabs#291)

* set decimals in postUpgradeInit

* more intentional function name

* comment

* call it postUpgradeInit

* add zero check

* Apply 7702 patch

* Updated slither

* Linting

* Storage formatting changes

* Added post upgrade init signature

* Added post upgrade init sig

* chore: v2.1.3

---------

Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com>
Co-authored-by: gzeon <hng@offchainlabs.com>
Co-authored-by: gzeon <im@gzeon.dev>

* Celestia DA & Blobstream

* merge

* Update nitro scripts (#25)

* Update scripts to use EspressoTEEVerifier

* Update scripts to use EspressoTEEVerifier

* address comments

* check for undefined config

* address comments and fix typo

(cherry picked from commit e97eccc)

* Update SequencerInboxStub to fix tests (#26)

(cherry picked from commit dd30940)

* Fix hardhat verification on arbSepolia (#29)

(cherry picked from commit ebecb09)

* merge

* merge

* add names (#33)

(cherry picked from commit 998a437)

* Add names to the deprecated functions to not break abi (#34)

* Add names to the deprecated functions to not break abi

* remove unwanted changes

(cherry picked from commit 418efec)

* Audit fixes (#37)

* Audit fixes

* transfer ownership two step

* fix contract

(cherry picked from commit 38831d5)

* merge

* use nightly version of foundry

* fix build

* add hardhat verify

* fix hardhat dependancy

* remove broken test

* remove broken test from build

---------

Co-authored-by: Chris Buckland <cpbuckland88@gmail.com>
Co-authored-by: Goran Vladika <goran.vladika@gmail.com>
Co-authored-by: gzeon <hng@offchainlabs.com>
Co-authored-by: gzeon <im@gzeon.dev>
Co-authored-by: Fionna <13184582+fionnachan@users.noreply.github.com>
Co-authored-by: Derek <103802618+leeederek@users.noreply.github.com>
Co-authored-by: Ganesh Vanahalli <gvanahalli@offchainlabs.com>
Co-authored-by: Joshua Colvin <jcolvin@offchainlabs.com>
Co-authored-by: Lee Bousfield <ljbousfield@gmail.com>
Co-authored-by: Jeremy <297323986@qq.com>
Co-authored-by: Tsahi Zidenberg <tsahi@offchainlabs.com>
Co-authored-by: Gabriel de Quadros Ligneul <8294320+gligneul@users.noreply.github.com>
Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com>
Co-authored-by: Diego <diego@celestia.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants