feat: always send batch posting report#325
Closed
gzeoneth wants to merge 2 commits intocustom-fee-rollupfrom
Closed
feat: always send batch posting report#325gzeoneth wants to merge 2 commits intocustom-fee-rollupfrom
gzeoneth wants to merge 2 commits intocustom-fee-rollupfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In v3.0.0 and earlier versions, custom fee token chains do not send batch posting reports at all so that data fee would not be charged on the child chain. With this purposed change, we will change the behavior such that batch posting reports are always sent. This would require legacy chains to make some call to ArbOwner (e.g. setPerBatchGasCharge(0)) to preserve the legacy behaviors.