Merged
Conversation
…m/OffchainLabs/nitro-contracts into deterministic-factory-deployments
* disable CBOR * chore: remove entries for removed files * refactor: commonSetting * feat: foundry override * fix: test * chore: default profile * format: yarn format * ci: comapre bytecodes * fix: slither db --------- Co-authored-by: gzeon <im@gzeon.dev>
gzeoneth
force-pushed
the
deterministic-factory-deployments-osp
branch
from
6c05772 to
fdd217d
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds a new deployment script to automate the OneStepProofEntry contract deployment.
- Introduces
deployOsp.tsunder/scriptsto deploy OneStepProofEntry and its dependencies - Reads
CUSTOM_DA_VALIDATORandDISABLE_VERIFICATIONfrom environment for configuration - Logs deployer info, network, and warns if the custom validator has no code
Comments suppressed due to low confidence (3)
scripts/deployOsp.ts:37
- [nitpick] The
ospproperty in the deployment result is short for OneStepProofEntry; consider using a more descriptive name likeproofEntryfor clarity.
console.log('OneStepProofEntry:', deployment.osp.address)
scripts/deployOsp.ts:1
- [nitpick] Add a header comment or README link explaining how to run this script and documenting the expected environment variables (
CUSTOM_DA_VALIDATOR,DISABLE_VERIFICATION).
import { ethers } from 'hardhat'
scripts/deployOsp.ts:9
- [nitpick] Consider validating that
CUSTOM_DA_VALIDATORis a valid Ethereum address usingethers.utils.isAddressbefore using it to fetch code.
process.env.CUSTOM_DA_VALIDATOR || ethers.constants.AddressZero
2471fa9 to
ca42e86
Compare
gzeoneth
changed the base branch from
deterministic-factory-deployments-parallel
to
deterministic-factory-deployments
…actory-deployments-osp
Base automatically changed from
deterministic-factory-deployments
to
develop
September 9, 2025 19:31
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TucksonDev
reviewed
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For use with #357 later, should revert 0c6ae28 and 7933dcc