feat: NO_PARALLEL_DEPLOYMENT#368
Closed
gzeoneth wants to merge 5 commits intodeterministic-factory-deployments-parallelfrom
Closed
feat: NO_PARALLEL_DEPLOYMENT#368gzeoneth wants to merge 5 commits intodeterministic-factory-deployments-parallelfrom
gzeoneth wants to merge 5 commits intodeterministic-factory-deployments-parallelfrom
Conversation
…inistic-factory-deployments-series
…inistic-factory-deployments-series
…inistic-factory-deployments-series
There was a problem hiding this comment.
Pull Request Overview
This PR adds a “NO_PARALLEL_DEPLOYMENT” feature flag to switch between parallel and serial contract deployments, introducing a deployBatch helper and mutex locking for serial mode.
- Introduces
deployLockand refactors deployment flows to respect theNO_PARALLEL_DEPLOYMENTenv var. - Adds a
deployBatchhelper to sequence or parallelize deployment functions. - Updates
deployContract,create2,deployAllContracts, anddeployOneStepProofEntryto use serial/parallel logic.
Comments suppressed due to low confidence (2)
scripts/deploymentUtils.ts:140
- [nitpick] The local variable
useSerialDeploymentis named differently fromisSerialDeploymentused elsewhere. Consider unifying this to a single name for consistency.
const useSerialDeployment = process.env.NO_PARALLEL_DEPLOYMENT === 'true'
scripts/deploymentUtils.ts:188
- [nitpick] The new
deployBatchhelper implementing serial vs. parallel flows is not covered by existing tests. Adding unit tests or integration tests for both modes will help prevent regressions.
async function deployBatch<T>(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POC, dirty hack; should pass isSerialDeployment into internal methods instead of reading from env everytime