Conversation
Contributor
|
we should link to the C4 report in the code comments IMO |
gzeoneth
requested changes
Nov 5, 2025
src/rollup/RollupCore.sol
Outdated
Comment on lines
+233
to
+239
| /** | ||
| * @notice Retrieves all currently registered stakers | ||
| */ | ||
| function getAllStakers() public view returns (address[] memory) { | ||
| return _stakerList; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
we don't need this, RollupAdminLogic can access private _stakerList in RollupCore
for offchain usage we also have getStakerAddress and stakerCount
gzeoneth
requested changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to reduce the base stake used in the rollup contract. Additional check to ensure this occurs in the permissionless domain