[NIT-2799] Add mock external signer #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amsanghi
changed the title
eljobe
approved these changes
Jan 6, 2025
Member
eljobe
left a comment
eljobe
left a comment
There was a problem hiding this comment.
Please update the commit description to say more than a reference to the Linear ticket since folks who are reading this repository from outside of OCL, can still read about the motivation for this change when looking at the commit logs.
Contributor
Author
Done. |
Tristan-Wilson
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: NIT-2799
Currently, there isn't a configuration on the nitro test node that uses the external signer feature. In this PR, we are adding an optional flag to test that enables an external signer. Instead of using the secure signer, which is non-trivial to set up, we are creating a new binary in the nitro repository that mocks the external signer interface. This binary receives the account private key as a command-line argument and start a RPC server.