Skip to content

Conversation

@eljobe
Copy link
Member

@eljobe eljobe commented Apr 3, 2025

This is a merge commit just prior to releasing a new version of Nitro and the consensus files.

Tristan-Wilson and others added 30 commits October 10, 2024 12:16
This adds a command for deploying the ExpressLaneAuction contract:
docker compose run scripts deploy-express-lane-auction

Since the contracts branch with ExpressLaneAuction is not published to
NPM this commit adds a way for it to be included from the local
workspace into the scripts docker image with the --dev-contracts flag.
The bash and docker logic here needs to be cleaned up so that it will
use the NPM version when not using the --dev-contracts flag.

The commit includes WIP code for initializing the contract.
Open ports and set up auth endpoint correctly on sequencer.
Deploy auction contract with l2owner instead of auctioneer accounts
(admin account on proxy contract cannot make calls on the proxied-to
contract).
The default value in nitro should work.
Even if using an nitro image that doesn't have timeboost enabled yet,
nitro will still start after logging an error message.
Unavailable modules in HTTP API list     unavailable=[timeboost] available="[admin debug web3 eth txpool personal net arb arbdebug arbtrace]"
ReserveSubmissionSeconds represents a period BEFORE the auction closes
that the reserve price may be updated for the next round. The previous
setting of 45 seconds means that the reserve price could not be updated
at all after the round started, coupled with the auction closing period
of 15 seconds (round duration is 60 seconds).
Disable this feature because the testnode doesn't support finalized
blocks.
…creation

Set ensure-rollup-deployment to false
Advertise http port instead of ws port to sequencer coordinator.
Only the http APIs are configured in the docker-compose.yaml so it
behaves more like you would expect.

Restart all initial sequencers instead of just "sequencer" when setting
up timeboost.
Also remove jwt token for auctioneer api.
@eljobe eljobe requested a review from Tristan-Wilson April 3, 2025 11:53
@cla-bot cla-bot bot added the s label Apr 3, 2025
@eljobe eljobe requested review from joshuacolvin0 and tsahee April 4, 2025 13:39
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eljobe eljobe merged commit 7061f1b into release Apr 5, 2025
27 checks passed
@tsahee tsahee deleted the merge-master-release branch September 29, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants