-
Notifications
You must be signed in to change notification settings - Fork 97
Merge master release #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Merge master release #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a command for deploying the ExpressLaneAuction contract: docker compose run scripts deploy-express-lane-auction Since the contracts branch with ExpressLaneAuction is not published to NPM this commit adds a way for it to be included from the local workspace into the scripts docker image with the --dev-contracts flag. The bash and docker logic here needs to be cleaned up so that it will use the NPM version when not using the --dev-contracts flag. The commit includes WIP code for initializing the contract.
Open ports and set up auth endpoint correctly on sequencer. Deploy auction contract with l2owner instead of auctioneer accounts (admin account on proxy contract cannot make calls on the proxied-to contract).
The default value in nitro should work.
Even if using an nitro image that doesn't have timeboost enabled yet, nitro will still start after logging an error message. Unavailable modules in HTTP API list unavailable=[timeboost] available="[admin debug web3 eth txpool personal net arb arbdebug arbtrace]"
ReserveSubmissionSeconds represents a period BEFORE the auction closes that the reserve price may be updated for the next round. The previous setting of 45 seconds means that the reserve price could not be updated at all after the round started, coupled with the auction closing period of 15 seconds (round duration is 60 seconds).
Disable this feature because the testnode doesn't support finalized blocks.
…creation Set ensure-rollup-deployment to false
… is enabled (required for timeboost)
…flag' into timeboost-mode
Advertise http port instead of ws port to sequencer coordinator. Only the http APIs are configured in the docker-compose.yaml so it behaves more like you would expect. Restart all initial sequencers instead of just "sequencer" when setting up timeboost.
Also remove jwt token for auctioneer api.
Master release merge
…_beacon_chain_genesis
Timeboost mode for nitro-testnode
…te-nitro-version Fix timeboost flag and update nitro ver
This pulls in the Abi files for contract changes that are active on the `master` branch of the nitro repository.
Update the blockscout pin
joshuacolvin0
approved these changes
Apr 4, 2025
Member
joshuacolvin0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a merge commit just prior to releasing a new version of Nitro and the consensus files.